[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15462: Document waitTimeoutOnBackpressureMillis parameter for the BK client

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #15462:
URL: https://github.com/apache/pulsar/pull/15462#discussion_r867244689


##########
conf/broker.conf:
##########
@@ -930,6 +930,22 @@ bookkeeperExplicitLacIntervalInMills=0
 # Expose bookkeeper client managed ledger stats to prometheus. default is false
 # bookkeeperClientExposeStatsToPrometheus=false
 
+# Timeout controlling wait on request send in case of unresponsive bookie(s).
+#    Timeout value:
+#         - negative value disables the feature
+#         - positive to allow wait up to specified number of milliseconds
+#         - 0 to allow request to fail immediately.
+#    Default is -1 (disabled)
+#########
+#  # Should be used in combination with the bookkeeper server-side
+#  #           backpressure configuration, such as
+#  #   maxAddsInProgressLimit = (positive value)
+#  #   maxReadsInProgressLimit = (positive value)
+#  #   closeChannelOnResponseTimeout = true
+#  #   waitTimeoutOnResponseBackpressureMs = (positive value)
+#########
+# bookkeeper_waitTimeoutOnBackpressureMillis = -1

Review Comment:
   Is there a reason we should keep this config commented out? I think it would be helpful to make this a first class member of this file so that users don't need to add the `PULSAR_PREFIX_` to the env var.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org