You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/10/28 05:51:35 UTC
Review Request 39708: Removed redundant code for conversion from PID
to HTTP based frameworks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39708/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Summary (updated)
-----------------
Removed redundant code for conversion from PID to HTTP based frameworks
Repository: mesos
Description (updated)
-------
This conversion logic is redundant and is already being taken care of as part of the `updateConnection` function.
https://github.com/apache/mesos/blob/master/src/master/master.hpp#L1736
Diffs (updated)
-----
src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
Diff: https://reviews.apache.org/r/39708/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 39708: Removed redundant code for conversion from
PID to HTTP based frameworks
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39708/#review104332
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 28, 2015, 4:51 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39708/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:51 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This conversion logic is redundant and is already being taken care of as part of the `updateConnection` function.
>
> https://github.com/apache/mesos/blob/master/src/master/master.hpp#L1736
>
>
> Diffs
> -----
>
> src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
>
> Diff: https://reviews.apache.org/r/39708/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 39708: Removed redundant code for conversion from
PID to HTTP based frameworks
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39708/#review104337
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 28, 2015, 4:51 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39708/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:51 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This conversion logic is redundant and is already being taken care of as part of the `updateConnection` function.
>
> https://github.com/apache/mesos/blob/master/src/master/master.hpp#L1736
>
>
> Diffs
> -----
>
> src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
>
> Diff: https://reviews.apache.org/r/39708/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>