[GitHub] [trafficserver] ema commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits

[GitBox <gi...@apache.org>]

ema commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r725937651



##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
    Represents the total number of closed HTTP/2 connections for not reaching the
    minimum average window increment limit which is configured by
    :ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer

Review comment:
       Ah yes, I see that there are currently no metrics using (1) `inbound` / `outbound`.
   
   I also see no `origin` version of  `proxy.process.http2.current_client_connections`, ie: there's no `proxy.process.http2.current_origin_connections`, so maybe let's not use (2).
   
   Given that there's no distinction for the streams exceeded metrics between requests and responses, we should avoid (4) too.
   
   By exclusion, that leaves us with (3): `proxy.process.http2.max_concurrent_streams_exceeded_(in|out)`.
   
   Let me know if that's fine with you and I'll update the PR accordingly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org