[GitHub] [arrow] bkietz commented on a diff in pull request #13613: ARROW-15582: [C++] Add support for registering standard Substrait functions

[GitBox <gi...@apache.org>]

bkietz commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r934907411


##########
cpp/src/arrow/engine/substrait/ext_test.cc:
##########
@@ -158,10 +152,10 @@ TEST_P(ExtensionIdRegistryTest, ReregisterFunctions) {
   auto provider = std::get<0>(GetParam());
   auto registry = provider->get();
 
-  for (util::string_view name : kFunctionNames) {
-    auto id = Id{kArrowExtTypesUri, name};
-    ASSERT_RAISES(Invalid, registry->CanRegisterFunction(id, name.to_string()));
-    ASSERT_RAISES(Invalid, registry->RegisterFunction(id, name.to_string()));
+  for (Id function_id : kFunctionIds) {

Review Comment:
   For anything trivial(ly copyable, destructible, ...) by-reference and by-value should be interchangeable. Using it by value here is more readable so do that. The compiler will have no difficulty removing the trivial copy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org