You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/03/14 08:23:54 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1533: MINIFICPP-2078 Remove cleanup from __del__ functions

lordgamez opened a new pull request, #1533:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1533

   Cleaning up docker resources is done manually in the behave `environment.py` file manually by calling the `cleanup` functions. The was cleanup is also called redundantly from the resources' `__del__` function which is called by the GC at unpredictable times. This caused that the docker remove function could be called while a new container with the same name is instantiated in a next test case which killed that container.
   
   https://issues.apache.org/jira/browse/MINIFICPP-2078
   
   ---------------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #1533: MINIFICPP-2078 Remove cleanup from __del__ functions

Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on PR #1533:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1533#issuecomment-1467667572

   Should we remove the `__del__` function from `DockerTestDirectoryBindings`, too, or is that one harmless?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1533: MINIFICPP-2078 Remove cleanup from __del__ functions

Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink closed pull request #1533: MINIFICPP-2078 Remove cleanup from __del__ functions
URL: https://github.com/apache/nifi-minifi-cpp/pull/1533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1533: MINIFICPP-2078 Remove cleanup from __del__ functions

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #1533:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1533#issuecomment-1467674223

   > Should we remove the `__del__` function from `DockerTestDirectoryBindings`, too, or is that one harmless?
   
   I checked and that can be kept as it only handles temp directories and those can be kept until the end of the test runs, so they should be harmless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org