You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/11 17:15:33 UTC
[GitHub] [airflow] ashb opened a new pull request #10887: Fix `breeze -i` error
ashb opened a new pull request #10887:
URL: https://github.com/apache/airflow/pull/10887
It was erroring with "unbound" variable, expecting INTEGRATION to be a
pre-defined variable.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487291199
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487291199
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691284605
Changing it definately made it work and behave as expected. `./breeeze -b mysql -i redis -i rabbitmq` was what I was running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10887:
URL: https://github.com/apache/airflow/pull/10887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271881
Hmm . but this is strange. It shoudl work actually, was it 'undefined' because there was no actual integration after -i ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487263295
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487263295
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271300
one lowercase too much
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691284605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691318858
> I thought I tired this, and it then couldn't find the list of allowed values.
True,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487291199
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#issuecomment-691287862
See my suggestion - this was the actual problem -> the "check_and_save_allowed_param" continued checking INTEGRATION variable instead if "integration"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10887:
URL: https://github.com/apache/airflow/pull/10887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10887:
URL: https://github.com/apache/airflow/pull/10887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487263295
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487291199
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
I thought I tired this, and it then couldn't find the list of allowed values.
I will double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10887: Fix `breeze -i` error
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10887:
URL: https://github.com/apache/airflow/pull/10887#discussion_r487263295
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
##########
File path: breeze
##########
@@ -724,14 +724,14 @@ function breeze::parse_arguments() {
shift 2
;;
-i | --integration)
- local integration=${2}
+ local INTEGRATION=${2}
parameters::check_and_save_allowed_param "INTEGRATION" "integration" "--integration"
Review comment:
```suggestion
parameters::check_and_save_allowed_param "integration" "integration" "--integration"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org