[GitHub] eolivelli commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting
URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241735828
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java
 ##########
 @@ -73,6 +74,10 @@
 
     protected static final String JAVA_FILES = "**\\/*.java";
 
+    private static final String CHECKSTYLE_FILE_HEADER = "<?xml version=\"1.0\"?>\n"
+            + "<!DOCTYPE module PUBLIC \"-//Puppy Crawl//DTD Check Configuration 1.3//EN\"\n"
+            + "        \"http://www.puppycrawl.com/dtds/configuration_1_3.dtd\">\n";
 
 Review comment:
   is is "<!DOCTYPE..." required ? or can we just keep "<?xml version=\"1.0\"?>" ?
   @Serranya  @rnveach
   this way we won't hard code such DTD.
   
   AFAIK DTD are useful for validation at runtime

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services