You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/09/08 14:56:08 UTC
[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1389: [SYSTEMDS-3114] Support for replace on frames CP
OlgaOvcharenko opened a new pull request #1389:
URL: https://github.com/apache/systemds/pull/1389
Modification of the existing frames replace, now replace is supported not only for string, but also integer, double and boolean columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1389: [SYSTEMDS-3114] Support for replace on frames CP
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1389:
URL: https://github.com/apache/systemds/pull/1389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1389: [SYSTEMDS-3114] Support for replace on frames CP
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1389:
URL: https://github.com/apache/systemds/pull/1389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1389: [SYSTEMDS-3114] Support for replace on frames CP
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1389:
URL: https://github.com/apache/systemds/pull/1389#issuecomment-917146513
Thanks for starting the work on exposing the frame replace and making it more robust. For use at script level, please introduce copy on write semantics with shallow copy of unmodified columns. Right now the implementation does a shallow copy for all columns and then modifies these columns in place, which changes both the output and input and thus, yields incorrect results (e.g., B=replace(A) also modifies A). Additional, please double check if the `UtilFunctions.objectToObject` and similar functions could be used to avoid conversions to string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1389: [SYSTEMDS-3114] Support for replace on frames CP
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1389:
URL: https://github.com/apache/systemds/pull/1389#issuecomment-917200741
sorry, you're right. I didn't realize that we already use this in a basic form, and the `new FrameBlock(this)` does an internal deep copy. Maybe try to shallow copy unaffected columns, but other than that it should be fine, but we need to investigate the failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org