You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/27 14:55:23 UTC
[GitHub] [rocketmq] mxsm opened a new pull request, #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
mxsm opened a new pull request, #4908:
URL: https://github.com/apache/rocketmq/pull/4908
**Make sure set the target branch to `develop`**
## What is the purpose of the change
close #4904
## Brief changelog
-Optimize store module test cases to reduce execution time
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654342
##########
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##########
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws Exception {
timeStart = putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
- timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+ timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();
+ ;
Review Comment:
It would be better to remove this useless line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654342
##########
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##########
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws Exception {
timeStart = putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
- timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+ timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();
+ ;
Review Comment:
It would be better remove this useless line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
Posted by GitBox <gi...@apache.org>.
RongtongJin merged PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
Posted by GitBox <gi...@apache.org>.
mxsm commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654913
##########
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##########
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws Exception {
timeStart = putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
- timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+ timeMid = putMessageResult.getAppendMessageResult().getStoreTimestamp();
+ ;
Review Comment:
> It would be better to remove this useless line
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#issuecomment-1229211382
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4908](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53e6aa0) into [develop](https://codecov.io/gh/apache/rocketmq/commit/2a46dbed19bf3e0613c01118c6277fc9b71a3813?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a46dbe) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 53e6aa0 differs from pull request most recent head 9fee8fa. Consider uploading reports for the commit 9fee8fa to get more accurate results
```diff
@@ Coverage Diff @@
## develop #4908 +/- ##
=============================================
- Coverage 43.32% 43.15% -0.17%
+ Complexity 7707 7676 -31
=============================================
Files 994 994
Lines 68938 68938
Branches 9132 9132
=============================================
- Hits 29865 29751 -114
- Misses 35330 35450 +120
+ Partials 3743 3737 -6
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `39.22% <0.00%> (-10.50%)` | :arrow_down: |
| [...apache/rocketmq/store/queue/ConsumeQueueStore.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0NvbnN1bWVRdWV1ZVN0b3JlLmphdmE=) | `53.41% <0.00%> (-5.56%)` | :arrow_down: |
| [...etmq/namesrv/routeinfo/BatchUnRegisterService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQmF0Y2hVblJlZ2lzdGVyU2VydmljZS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...e/rocketmq/store/ha/autoswitch/EpochFileCache.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvRXBvY2hGaWxlQ2FjaGUuamF2YQ==) | `77.08% <0.00%> (-4.17%)` | :arrow_down: |
| [...ache/rocketmq/store/AllocateMappedFileService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FsbG9jYXRlTWFwcGVkRmlsZVNlcnZpY2UuamF2YQ==) | `39.28% <0.00%> (-2.39%)` | :arrow_down: |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `53.40% <0.00%> (-2.06%)` | :arrow_down: |
| [...mq/store/ha/autoswitch/AutoSwitchHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ29ubmVjdGlvbi5qYXZh) | `73.02% <0.00%> (-1.91%)` | :arrow_down: |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `58.11% <0.00%> (-1.71%)` | :arrow_down: |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `81.42% <0.00%> (-1.43%)` | :arrow_down: |
| [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `69.86% <0.00%> (-1.37%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org