[CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

[Benedikt Ritter <br...@apache.org>]

... moving this to a new thread.

The name isIgnoreEmptyHeaders seems to cause confusion, since in this case
an entry in the header is meant and not the whole header (like in
skipHeaderRecord)

The JavaDoc of isIgnoreEmptyHeaders is:

    /**
     * Specifies whether empty headers are ignored when parsing the header
line.
     *
     * @return <tt>true</tt> if headers are ignored when parsing the header
line, <tt>false</tt> to throw an
     *         {@link IllegalArgumentException}.
     */

If we want to use the term column names to make the distinction to the
header as a whole, "isAllowingMissingColumnNames" sounds like the way to go
to me.

Do you have an alternative?

br,
Benedikt


2014-07-18 22:25 GMT+02:00 Gary Gregory <ga...@gmail.com>:

> On Fri, Jul 18, 2014 at 4:01 PM, Benedikt Ritter <be...@gmail.com>
> wrote:
>
> > I think "isAllowingMissingColumnNames" is a good name.
> >
>
> That does not real well at all unfortunately.
>
> Gary
>
>
> >
> > Send from my mobile device
> >
> > > Am 18.07.2014 um 17:43 schrieb Emmanuel Bourg <eb...@apache.org>:
> > >
> > > Le 18/07/2014 17:37, Gary Gregory a écrit :
> > >
> > >> So what do you call the individual names in a header record?
> > >
> > > A column name. That's the term used in CSVRecord.
> > >
> > > Emmanuel Bourg
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

[Benedikt Ritter <br...@apache.org>]

Any thoughts about this? I still think isAllowingEmptyColumnNames() is a
good name.​ :)

Benedikt