You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/29 18:00:05 UTC
[GitHub] [pinot] sudo6si opened a new issue, #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
sudo6si opened a new issue, #9491:
URL: https://github.com/apache/pinot/issues/9491
Currently helm chart's [`values.yaml` file](https://github.com/apache/pinot/blob/dc84310077765ce367d380c97aa67f9e4caeb0bf/kubernetes/helm/pinot/values.yaml#L102) contains following option:
```
jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log"
```
As per my [understanding](https://stackoverflow.com/a/59882645)
> Overrides the number of CPUs that the VM will use to calculate the size of thread pools it will use for various operations such as Garbage Collection and ForkJoinPool.
Do we need this option and should this be configured to be equal to container's CPU?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] sudo6si commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
sudo6si commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1262663817
@xiangfu0 thanks for the quick revert. We have removed this option entirely and assuming that pinot's JVM is smart enough to figure out how much CPU is available for it?
If that is not the case, let me know and we will set the value to be equal to container's CPU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1262658394
This is usually be configured when try users started with a very small VM. We do see problems that some users configure <1 CPU for pinot and that might cause unexpected behavior of the program, as the java system gives you that you have 0 CPU.
For advanced users, definitely modify it as you needed or just remove this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] sudo6si closed issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
sudo6si closed issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
URL: https://github.com/apache/pinot/issues/9491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1262665114
> ave removed this option entirely and assuming that pinot's JVM is smart enough to figure out how much CPU is available for it?
Feel free to remove, this is the safeguard for extreme low resources users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] sudo6si commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
sudo6si commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1262788307
Thanks for the explanation. Closing this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1263875144
I think we can have a reasonable default one and meanwhile prepare a few `values.yaml` recipes for different usages, e.g. values-dev.yaml or values-small,yaml, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ksnijjer commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
ksnijjer commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1263861727
@xiangfu0 I would suggest that we get rid of this flag in default settings in first place, and simply add a highlighted note which recommends users to explicitly set this config as and when needed. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ksnijjer commented on issue #9491: Do we need `-XX:ActiveProcessorCount=2` in jvmOpts?
Posted by GitBox <gi...@apache.org>.
ksnijjer commented on issue #9491:
URL: https://github.com/apache/pinot/issues/9491#issuecomment-1263881790
That seems like a better approach, thanks @xiangfu0!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org