You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/09 23:34:04 UTC
[GitHub] [camel] rhuan080 opened a new pull request, #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
rhuan080 opened a new pull request, #7756:
URL: https://github.com/apache/camel/pull/7756
… component
Signed-off-by: Rhuan Rocha <rh...@gmail.com>
Enabling to use service account key as base64.
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
rhuan080 commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1152008276
Updated! I`ll upgrade the guide! Thank you @davsclaus :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1151927313
There should already be support for this out of the box
org.apache.camel.impl.engine.DefaultResourceResolvers.Base64Resolver
Does it not already work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #7756:
URL: https://github.com/apache/camel/pull/7756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1151712351
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1152046944
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (63 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1151742707
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1152034546
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (63 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
rhuan080 commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1152659484
I sent a PR to update the doc --> https://github.com/apache/camel/pull/7763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1151981616
> I think we should rename the option keyResource to serviceAccountKey.
Yeah if its for this then a better name is a good idea. You are welcome to rename the option.
We then need to add a note in the 3.18 upgrade guide at about this:
https://github.com/apache/camel/blob/main/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_18.adoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #7756: CAMEL-18170 - Enabling to serviceAccountKey as base64 to google-drive…
Posted by GitBox <gi...@apache.org>.
rhuan080 commented on PR #7756:
URL: https://github.com/apache/camel/pull/7756#issuecomment-1151978086
Hi @davsclaus,
Yes! Actually, it is working. Thus, I think the issue was a misunderstanding caused by the option name. The BigQuery use the `serviceAccountKey` name and the google drive (and remaining components) uses `keyResource`. Thus, I think the changes are just about docs.
I think we should rename the option `keyResource` to `serviceAccountKey`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org