You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Noorul Islam K M <no...@collab.net> on 2010/11/18 06:54:04 UTC

[PATCH] Fix for issue 3620 - relocate command

Log

[[[

Make 'svn relocate' verify that the target working copy root dir is
local.

* subversion/libsvn_client/relocate.c,
  subversion/svn/relocate-cmd.c
  (svn_client_relocate2, svn_cl__relocate): Raise an error if target
  working copy dir is not local.

* subversion/tests/cmdline/input_validation_tests.py
  (invalid_relocate_targets, test_list): New test.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>

]]]

Thanks and Regards
Noorul


Re: [PATCH] Fix for issue 3620 - relocate command

Posted by Julian Foad <ju...@wandisco.com>.
Noorul Islam K M wrote:
> Make 'svn relocate' verify that the target working copy root dir is
> local.

Thanks.  Committed in r1036383.

> +  if (svn_path_is_url(wcroot_dir))
> +    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,

I tweaked this line, removing svn_error_return() as it's redundant when
using svn_error_create*().

> +                                              _("'%s' is not a local path"),
> +                                              wcroot_dir));

- Julian