[GitHub] [helix] jiajunwang commented on a change in pull request #1937: Remove duplicate log in HelixTaskExecutor

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1937:
URL: https://github.com/apache/helix/pull/1937#discussion_r792957605



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -1312,12 +1312,9 @@ private Message markReadMessage(Message message, NotificationContext context,
 
   private void updateUnprocessableMessage(Message message, Exception exception, String errorMsg,
       HelixManager manager) {
-    String error = "Message " + message.getMsgId() + " cannot be processed: " + message.getRecord();
     if (exception != null) {
-      LOG.error(error, exception);
-      _statusUpdateUtil.logError(message, HelixStateMachineEngine.class, exception, error, manager);
+      _statusUpdateUtil.logError(message, HelixStateMachineEngine.class, exception, errorMsg, manager);
     } else {
-      LOG.error(error + errorMsg);
       _statusUpdateUtil.logError(message, HelixStateMachineEngine.class, errorMsg, manager);
     }

Review comment:
       I think we just need to remove the regular log behavior in _statusUpdateUtil. So it only writes to file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org