[GitHub] [doris] weizuo93 commented on a diff in pull request #18421: [enhancement](load) merge single-replica related services as non-standalone

["weizuo93 (via GitHub)" <gi...@apache.org>]

weizuo93 commented on code in PR #18421:
URL: https://github.com/apache/doris/pull/18421#discussion_r1168110824


##########
be/src/http/action/download_action.cpp:
##########
@@ -114,6 +126,14 @@ void DownloadAction::handle_error_log(HttpRequest* req, const std::string& file_
 }
 
 void DownloadAction::handle(HttpRequest* req) {
+    if (_is_async) {

Review Comment:
   why is this asynchronous? Could you add some comments please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org