You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2019/02/14 08:54:00 UTC
[jira] [Commented] (HBASE-21899) Fix missing variables in slf4j
Logger
[ https://issues.apache.org/jira/browse/HBASE-21899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768010#comment-16768010 ]
Duo Zhang commented on HBASE-21899:
-----------------------------------
+1.
> Fix missing variables in slf4j Logger
> -------------------------------------
>
> Key: HBASE-21899
> URL: https://issues.apache.org/jira/browse/HBASE-21899
> Project: HBase
> Issue Type: Bug
> Components: logging
> Affects Versions: 2.1.3
> Reporter: Daisuke Kobayashi
> Priority: Trivial
>
> I happened to find the following methods have called slf4j Logger without variables whereas {} exists.
> org.apache.hadoop.hbase.master.procedure.ReopenTableRegionsProcedure#executeFromState
> org.apache.hadoop.hbase.replication.regionserver.SerialReplicationChecker#canPush(org.apache.hadoop.hbase.wal.WAL.Entry, org.apache.hadoop.hbase.Cell)
> With my quick patch, I was able to log the condition appropriately at least for SerialReplicationChecker.
> {noformat}
> 2019-02-14 02:34:46,365 TRACE [Time-limited test] regionserver.SerialReplicationChecker(258): The sequence id for Mock for Entry, hashCode: 2138280514 is continuous, pass
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)