[GitHub] [apisix] dabue commented on a change in pull request #2374: chore: remove the folder 'logs' in root and replace baidu.com with github.com in test cases

[GitBox <gi...@apache.org>]

dabue commented on a change in pull request #2374:
URL: https://github.com/apache/apisix/pull/2374#discussion_r503659750



##########
File path: bin/apisix
##########
@@ -1065,6 +1065,9 @@ local openresty_args = [[openresty  -p ]] .. apisix_home .. [[ -c ]]
                        .. apisix_home .. [[/conf/nginx.conf]]
 
 function _M.start(...)
+
+    local cmd_logs = "mkdir -p " ..  apisix_home .. "/logs"

Review comment:
       > @dabue @membphis
   
   The directory logs is required when the APISIX is running. On the first running, it needs to be created if we keep the logs removed from the root, and should have the appropriate permissions.
   when the directory already exists, whether the directory is created by the first running or is from the beginning,  the permission to write logs are same.
   I'll do a test to verify it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org