You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/04/10 18:30:04 UTC
[jira] [Commented] (HADOOP-15009) hadoop-resourceestimator's shell
scripts are a mess
[ https://issues.apache.org/jira/browse/HADOOP-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080792#comment-17080792 ]
Hadoop QA commented on HADOOP-15009:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color} | {color:red} HADOOP-15009 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-15009 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12901745/HADOOP-15009.001.patch |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/16856/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> hadoop-resourceestimator's shell scripts are a mess
> ---------------------------------------------------
>
> Key: HADOOP-15009
> URL: https://issues.apache.org/jira/browse/HADOOP-15009
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts, tools
> Affects Versions: 3.1.0
> Reporter: Allen Wittenauer
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HADOOP-15009.001.patch, Screen Shot 2017-12-12 at 11.16.23 AM.png
>
>
> #1:
> There's no reason for estimator.sh to exist. Just make it a subcommand under yarn or whatever.
> #2:
> In it's current form, it's missing a BUNCH of boilerplate that makes certain functionality completely fail.
> #3
> start/stop-estimator.sh is full of copypasta that doesn't actually do anything/work correctly. Additionally, if estimator.sh doesn't exist, neither does this since yarn --daemon start/stop will do everything as necessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org