You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ifndef-SleePy <gi...@git.apache.org> on 2018/01/20 05:40:09 UTC

[GitHub] flink pull request #5322: [hotfix] [REST] Fix WebMonitorEndpoint that missin...

GitHub user ifndef-SleePy opened a pull request:

    https://github.com/apache/flink/pull/5322

    [hotfix] [REST] Fix WebMonitorEndpoint that missing parameters while initializing handlers

    ## What is the purpose of the change
    
    * Fix bugs in my recent PRs about migrating subtask REST handlers
    
    ## Brief change log
    
    * Some `MessageHeaders` are missing while initializing handlers in `WebMonitorEndpoint`
    * There is wrong parameter type in `SubtaskExecutionAttemptAccumulatorsHeaders`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alibaba/flink FLINK-REST-handlers-hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5322
    
----
commit 23dd66822352ae7d1d6f0e60494f9541c57714e8
Author: biao.liub <bi...@...>
Date:   2018-01-20T05:26:29Z

    [hotfix] [REST] Fix WebMonitorEndpoint that missing parameters while initializing handlers

----


---

[GitHub] flink issue #5322: [hotfix] [REST] Fix WebMonitorEndpoint that missing param...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5322
  
    Thanks for this fix @ifndef-SleePy. Merging it.


---

[GitHub] flink pull request #5322: [hotfix] [REST] Fix WebMonitorEndpoint that missin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5322


---