[GitHub] [beam] TheNeuralBit commented on pull request #16909: Introducing KafkaIO.Read implementation compatibility testing

[GitBox <gi...@apache.org>]

TheNeuralBit commented on PR #16909:
URL: https://github.com/apache/beam/pull/16909#issuecomment-1095406559

   Sorry for the delay here, this didn't make it into my workflow since I just left a drive-by comment and was never specifically requested to review with a R: comment or through the GitHub UI. This is my fault, I should have made sure this was captured, sorry about that.
   
   > What is the problem with reflection?
   
   It's just preferable to avoid reflection APIs since they can't be verified statically. But I agree that some verification is better than nothing, and I feel better knowing that we have a test to make sure this stays up to date.
   
   Given the above this LGTM. @chamikaramj or @kennknowles are you ok with the changes this PR makes to KafkaIO?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org