[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #273: upgrade to jackson 2.14.2

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#discussion_r1157028355


##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -134,7 +136,7 @@ object PekkoDisciplinePlugin extends AutoPlugin {
           case Some((2, 12)) =>
             disciplineScalacOptions
           case _ =>
-            Nil
+            Seq("-Wconf:cat=deprecation:s")

Review Comment:
   To provide some context, this flag is needed for Scala 3.2.x in general, not Jackson specifically. It appears there was an issue in Scala 3.1.x where it wasn't reporting deprecations as it should and this was fixed in Scala 3.2. I also had to the do the same fix in the PR I created that **only** updates to Scala 3.3 (with no other changes), see https://github.com/apache/incubator-pekko/pull/270/files#diff-676691b2e85cad6026adb107942b7c9325394e20e015b131fdcebd3b2b7794b0R137.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org