You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/08 14:23:30 UTC

[GitHub] [orc] zhjwpku opened a new pull request, #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

zhjwpku opened a new pull request, #1358:
URL: https://github.com/apache/orc/pull/1358

   timezone file might be hundreds or thousands of bytes, pass references of byte vector should be more efficient.
   
   Signed-off-by: Junwang Zhao <zh...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on a diff in pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
wgtmac commented on code in PR #1358:
URL: https://github.com/apache/orc/pull/1358#discussion_r1064248763


##########
c++/src/Timezone.cc:
##########
@@ -565,7 +565,7 @@ namespace orc {
 
   class TimezoneImpl : public Timezone {
    public:
-    TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes);
+    TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes);

Review Comment:
   nit: the function parameter names are inconsistent between declaration and definition. It would be nice to make them consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac merged pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
wgtmac merged PR #1358:
URL: https://github.com/apache/orc/pull/1358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1358:
URL: https://github.com/apache/orc/pull/1358#discussion_r1064252557


##########
c++/src/Timezone.cc:
##########
@@ -565,7 +565,7 @@ namespace orc {
 
   class TimezoneImpl : public Timezone {
    public:
-    TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes);
+    TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes);

Review Comment:
   +1 for the above comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] zhjwpku commented on pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on PR #1358:
URL: https://github.com/apache/orc/pull/1358#issuecomment-1375023714

   > BTW, please preserve the Apache ORC PR description template like #1331 .
   
   sure, PR description edited.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] zhjwpku commented on a diff in pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on code in PR #1358:
URL: https://github.com/apache/orc/pull/1358#discussion_r1064253678


##########
c++/src/Timezone.cc:
##########
@@ -565,7 +565,7 @@ namespace orc {
 
   class TimezoneImpl : public Timezone {
    public:
-    TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes);
+    TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes);

Review Comment:
   yeah, resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1358:
URL: https://github.com/apache/orc/pull/1358#issuecomment-1375074815

   I just committed it. Thanks @zhjwpku and @dongjoon-hyun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org