You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 18:47:27 UTC
[GitHub] [spark] heyihong opened a new pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
heyihong opened a new pull request #35687:
URL: https://github.com/apache/spark/pull/35687
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
- Add magic method \_\_enter\_\_ and \_\_exit\_\_ into **the special function list**
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
- Improve the instrumentation accuracy for with statement so that external \_\_enter\_\_ and \_\_exit\_\_ calls are captured instead of internal calls
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1054684495
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057965408
Merged to master and branch-3.2.
:-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas API on Spark
Posted by GitBox <gi...@apache.org>.
heyihong commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1058300837
> Emm, PR's description is really unfriendly for me. lol, after take a deep look, it enables usage logger in Pandas on Spark for ContextManager usage, record in `__enter__` and `__exit__`.
>
> LGTM.
This pr probably cannot fix the accuracy issue for functions with @contextmanager decorator. I am going to have another pull request to address that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1055944686
Could you elaborate more detail why do we need `__enter__` and `__exit__` to the usage log for pandas API on Spark ??
Why adding `__enter__` and `__exit__` improve the instrumentation accuracy for example ?
And could you also fill the description for JIRA ticket (https://issues.apache.org/jira/browse/SPARK-38353) ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057370380
Thanks! I made some minor fix from the JIRA title and description.
Could you address some nits below:
- `Pandas module` to `pandas API on Spark` in the PR title.
- `pandas usage logger` to `pandas-on-Spark usage logger` in the PR description.
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1055944686
Could you elaborate more detail why do we need `__enter__` and `__exit__` to the usage log for pandas API on Spark ??
It would be great if we have an example to show the reason why adding `__enter__` and `__exit__` improves the instrumentation accuracy.
And could you also fill the description for JIRA ticket (https://issues.apache.org/jira/browse/SPARK-38353) ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
heyihong edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057227988
@itholic Sure, I updated both the PR and JIRA description about why do we need __enter__ and __exit__ to the usage log for pandas API on Spark with an example. Could you take another look when you time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas API on Spark
Posted by GitBox <gi...@apache.org>.
heyihong commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057962118
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
heyihong commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057227988
>
@itholic Sure, I updated both the PR and JIRA description about why do we need __enter__ and __exit__ to the usage log for pandas API on Spark with an example. Could you take another look when you time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057370380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35687:
URL: https://github.com/apache/spark/pull/35687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1056009229
cc @ueshin FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1055944686
Could you elaborate more detail why do we need `__enter__` and `__exit__` to the usage log for pandas API on Spark ??
It would be great if we have an example to show the reason why adding `__enter__` and `__exit__` improve the instrumentation accuracy ?
And could you also fill the description for JIRA ticket (https://issues.apache.org/jira/browse/SPARK-38353) ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057370380
Thanks! I made some minor fix from the JIRA title and description, `pandas module` -> `pandas API on Spark`.
Could you address the nit below:
- `Pandas module` to `pandas API on Spark` in the PR title.
- `pandas usage logger` to `pandas-on-Spark usage logger` in the PR description.
?
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1057966276
Congrats for being Apache Spark contributor @heyihong 🎊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org