[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6419: [BUG][ConvertLayout] Fixes AttributeError during ConvertLayout to NHWC

[GitBox <gi...@apache.org>]

lhutton1 commented on a change in pull request #6419:
URL: https://github.com/apache/incubator-tvm/pull/6419#discussion_r484837153



##########
File path: python/tvm/relay/op/nn/_nn.py
##########
@@ -157,8 +157,9 @@ def convert_conv2d(attrs, inputs, tinfos, desired_layouts):
         return relay.nn.conv2d(data, weight, **new_attrs)
     elif desired_data_layout == 'NHWC':
         # Check for depthwise convolution.
-        if is_depthwise_conv2d(data.shape, attrs['data_layout'], weight.shape,
-                               attrs['kernel_layout'], attrs['groups']):
+        if is_depthwise_conv2d(data.checked_type.shape, attrs['data_layout'],

Review comment:
       I think it's ok to leave without an assert, getting `checked_type` will result in a check for its existence. See: https://github.com/apache/incubator-tvm/blob/0465ffda26a4e9d64944f01b33b566b6663d3afe/python/tvm/ir/expr.py#L36




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org