You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/21 08:25:54 UTC

[GitHub] [iotdb] imquanke opened a new pull request, #6744: [IOTDB-3593] Broadcast latest ConfigNodeGroup

imquanke opened a new pull request, #6744:
URL: https://github.com/apache/iotdb/pull/6744

   ## We need to notify all DataNodes when the capacity of the ConfigNodeGroup is expanded or reduced.
   
   
   ### test results on condition: three configNodes, three dataNodes
   * one configNode and three dataNodes
   ![1](https://user-images.githubusercontent.com/39719966/180163901-d8f54f3e-a60b-4506-86b8-a651cba15120.png)
   * add another one configNode
   logs on the first configNode
   ![2](https://user-images.githubusercontent.com/39719966/180164999-1e6eb659-90d7-455b-b362-291289ce2a60.png)
   logs on the new configNode
   ![5](https://user-images.githubusercontent.com/39719966/180166238-c1884c5f-9a14-4044-8cae-8fec12c810d7.png)
   logs on dataNode
   ![3](https://user-images.githubusercontent.com/39719966/180165595-e25df88c-d10f-47db-a899-373f15b2436c.png)
   query result on cli
   ![4](https://user-images.githubusercontent.com/39719966/180165184-5b5f4b3f-dff4-4d21-88e3-8f274f6c74aa.png)
   * add another one configNode
   * kill the first configNode
   logs on the newly elected leader configNode
   ![6](https://user-images.githubusercontent.com/39719966/180166857-8cd4f014-b745-49cf-b9ec-ae10b7792a71.png)
   query result on cli
   ![8](https://user-images.githubusercontent.com/39719966/180167006-649b2fc5-99f7-4183-9765-b88c6a656cef.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] imquanke commented on a diff in pull request #6744: [IOTDB-3593] Broadcast latest ConfigNodeGroup

Posted by GitBox <gi...@apache.org>.
imquanke commented on code in PR #6744:
URL: https://github.com/apache/iotdb/pull/6744#discussion_r927253443


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/RemoveConfigNodeProcedure.java:
##########
@@ -76,6 +76,7 @@ protected Flow executeFromState(ConfigNodeProcedureEnv env, RemoveConfigNodeStat
           break;
         case STOP_CONFIG_NODE:
           env.stopConfigNode(tConfigNodeLocation);
+          env.broadCastTheLatestConfigNodeGroup();

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a diff in pull request #6744: [IOTDB-3593] Broadcast latest ConfigNodeGroup

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #6744:
URL: https://github.com/apache/iotdb/pull/6744#discussion_r927239315


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/RemoveConfigNodeProcedure.java:
##########
@@ -76,6 +76,7 @@ protected Flow executeFromState(ConfigNodeProcedureEnv env, RemoveConfigNodeStat
           break;
         case STOP_CONFIG_NODE:
           env.stopConfigNode(tConfigNodeLocation);
+          env.broadCastTheLatestConfigNodeGroup();

Review Comment:
   I feel broadCastTheLatestConfigNodeGroup should move REMOVE_CONFIG_NODE_PREPARE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 merged pull request #6744: [IOTDB-3593] Broadcast latest ConfigNodeGroup

Posted by GitBox <gi...@apache.org>.
wangchao316 merged PR #6744:
URL: https://github.com/apache/iotdb/pull/6744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org