You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/05/29 05:35:39 UTC

[PR] [backport camel-4.18.x] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]

oscerd opened a new pull request, #23616:
URL: https://github.com/apache/camel/pull/23616

   ## Backport of #23594 to `camel-4.18.x`
   
   Cherry-pick of #23594 (`CAMEL-23629`) onto `camel-4.18.x`, part of the [CAMEL-23577](https://issues.apache.org/jira/browse/CAMEL-23577) header-naming sweep. Target release: **4.18.3**.
   
   **Original PR:** #23594 — CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention
   **Jira:** https://issues.apache.org/jira/browse/CAMEL-23629
   
   ### Constants renamed
   
   | Constant | Previous value | New value |
   |---|---|---|
   | `IrcConstants.IRC_MESSAGE_TYPE`     | `irc.messageType`     | `CamelIrcMessageType`     |
   | `IrcConstants.IRC_TARGET`           | `irc.target`          | `CamelIrcTarget`          |
   | `IrcConstants.IRC_SEND_TO`          | `irc.sendTo`          | `CamelIrcSendTo`          |
   | `IrcConstants.IRC_USER_KICKED`      | `irc.user.kicked`     | `CamelIrcUserKicked`      |
   | `IrcConstants.IRC_USER_HOST`        | `irc.user.host`       | `CamelIrcUserHost`        |
   | `IrcConstants.IRC_USER_NICK`        | `irc.user.nick`       | `CamelIrcUserNick`        |
   | `IrcConstants.IRC_USER_SERVERNAME`  | `irc.user.servername` | `CamelIrcUserServername`  |
   | `IrcConstants.IRC_USER_USERNAME`    | `irc.user.username`   | `CamelIrcUserUsername`    |
   | `IrcConstants.IRC_NUM`              | `irc.num`             | `CamelIrcNum`             |
   | `IrcConstants.IRC_VALUE`            | `irc.value`           | `CamelIrcValue`           |
   
   ### Compatibility
   
   Java field names are unchanged — routes referencing the constants symbolically keep working. Routes using the literal `irc.*` string values must move to `CamelIrc*`.
   
   ### Backport notes
   
   - The only cherry-pick conflict was the upgrade-guide file: the source commit edits `camel-4x-upgrade-guide-4_21.adoc`, which does not exist on `camel-4.18.x`. Per the sweep convention, that hunk was dropped and the equivalent **"camel-irc - potential breaking change"** entry (rename table + cross-transport `HeaderFilterStrategy` note) was added to `camel-4x-upgrade-guide-4_18.adoc` instead, alongside the sibling sub-task entries. The canonical 4_18 guide on `main` is doc-synced separately as part of CAMEL-23577.
   - All code / catalog / endpoint-DSL files cherry-picked cleanly; `IrcConstants` on 4.18.x is not `@Deprecated` (deprecation is 4.21-only) and the rename applied without touching the class declaration.
   
   ### Local build
   
   Full reactor `mvn clean install -DskipTests` on `camel-4.18.x` — green (12923 goals, 11213 executed, 1710 cached), no uncommitted regen drift.
   
   _Claude Code on behalf of Andrea Cosentino_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [backport camel-4.18.x] CAMEL-23629: camel-irc - align Exchange header constant names with Camel naming convention [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #23616:
URL: https://github.com/apache/camel/pull/23616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org