You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/25 19:02:15 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
v01d opened a new pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648
# Summary
This change allows including Markdown files outside of the Documentation directory
# Impact
Documentation
# Testing
Tested including a Markdown file and displayed correctly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680224590
`pipenv install <package name>` should add it.
Otherwise recreate it from the requirements.txt `pipenv install -r requirements.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680236270
Ok, just added to gitignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680220826
I was about to ask how to do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680232343
Ok, I just force pushed the Pipfile change.
What about the `.python-version` file? Should this be pulled in or added to .gitignore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680235597
> What about the `.python-version` file? Should this be pulled in or added to .gitignore?
We should drop that. The rest looks good though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680218722
Can you update the pipenv file as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1648: documentation: switch to m2r2 for Markdown support; update requirements.txt
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1648:
URL: https://github.com/apache/incubator-nuttx/pull/1648#issuecomment-680235597
> What about the `.python-version` file? Should this be pulled in or added to .gitignore?
We should drop that. The rest looks good though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org