You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/03 06:30:23 UTC
[GitHub] [incubator-yunikorn-web] kobe860219 opened a new pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
kobe860219 opened a new pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61
### What is this PR for?
Showing "node sort policy" in UI dashboard.
### What type of PR is it?
* [ ] - Bug Fix
* [ x ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-654
### How should this be tested?
### Screenshots (if appropriate)
<img width="1422" alt="ζͺε 2021-08-02 δΈε3 18 20" src="https://user-images.githubusercontent.com/48027290/127968442-2be1cb69-917a-4dcb-96d0-2ed152244ce2.png">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894252347
@yangwwei The pre-commit check passed now. Thanks @akhilpb001 help. I disabled my IDE's prettier and use `yarn prettify` to format insteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894049371
Hi @kobe860219, this is unit test failure. Add following lines to `MockSchedulerService` in `mocks.ts` file to fix this.
```
fetchPartionList: () => of([]),
```
CC: @yangwwei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893622080
seems like the travis job is still failing: https://app.travis-ci.com/github/apache/incubator-yunikorn-web/jobs/529229491.
it says: The command "yarn test:coverage" exited with 1. @kobe860219 could u pls check this? you can run the same command locally as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on a change in pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#discussion_r683997845
##########
File path: src/app/app.component.ts
##########
@@ -55,11 +55,11 @@ export class AppComponent implements OnInit {
do {
const childrenRoutes = currentRoute.children;
currentRoute = null;
- childrenRoutes.forEach(route => {
+ childrenRoutes.forEach((route) => {
Review comment:
Please configure your editor (VS Code) to not to add bracket around single param in arrow function. If you are using VSCode and installed prettier, you can configure this in prettier extension settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894376762
thank you @kobe860219 for getting this done
and thank you @akhilpb001 for the review and suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893962927
@yangwwei It's the same error when I run the same command locally. The problem outputs the info `TypeError: this.scheduler.fetchPartitionList is not a function` . Currently, I have no idea why it occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 edited a comment on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
kobe860219 edited a comment on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893388090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] kobe860219 commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893388090
Hi @akhilpb001 ! There is aa error in pre-commit check. I found the problem below when `make test` :
I have no idea what cause it. If you available, could you give me some hints ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-892188139
thank you @kobe860219 for working on this, thank you @akhilpb001 for the review.
the pre-commit check fails, could u pls take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei closed pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
yangwwei closed pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on a change in pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61#discussion_r683997845
##########
File path: src/app/app.component.ts
##########
@@ -55,11 +55,11 @@ export class AppComponent implements OnInit {
do {
const childrenRoutes = currentRoute.children;
currentRoute = null;
- childrenRoutes.forEach(route => {
+ childrenRoutes.forEach((route) => {
Review comment:
Please configure your editor (VS Code) to not to add bracket around single param in arrow function. If you are using VSCode and installed prettier, you can configure this in prettier extension settings.
https://prettier.io/docs/en/options.html#arrow-function-parentheses
`prettier.arrowParens: "avoid"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei merged pull request #61: [YUNIKORN-654] Include node sorting policy in cluster page
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org