You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2014/06/23 22:14:48 UTC
svn commit: r1604924 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java
Author: jahewson
Date: Mon Jun 23 20:14:47 2014
New Revision: 1604924
URL: http://svn.apache.org/r1604924
Log:
PDFBOX-2161: A PDRadioButton with no children throws an NPE
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java?rev=1604924&r1=1604923&r2=1604924&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java Mon Jun 23 20:14:47 2014
@@ -144,7 +144,6 @@ public final class PDRadioButton extends
@SuppressWarnings("unchecked")
public List getKids() throws IOException
{
- List retval = null;
COSArray kids = (COSArray)getDictionary().getDictionaryObject(COSName.KIDS);
if( kids != null )
{
@@ -153,8 +152,11 @@ public final class PDRadioButton extends
{
kidsList.add( PDFieldFactory.createField( getAcroForm(), (COSDictionary)kids.getObject(i) ) );
}
- retval = new COSArrayList( kidsList, kids );
+ return new COSArrayList( kidsList, kids );
+ }
+ else
+ {
+ return new ArrayList();
}
- return retval;
}
}