You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2007/04/25 02:27:15 UTC
[jira] Created: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Investigate whether we can use component meta data for the storage of feedback messages
---------------------------------------------------------------------------------------
Key: WICKET-499
URL: https://issues.apache.org/jira/browse/WICKET-499
Project: Wicket
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Eelco Hillenius
Fix For: 1.3
Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
Advantages of doing this:
* it is a one-one mapping of the concept that you set a message on a component;
* you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
Disadvantages:
* no central storage place, making it harder to track.
* probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491573 ]
Johan Compagner commented on WICKET-499:
----------------------------------------
why need that cleanup?
If those messages are always cleanup after a request anyway. Then store them in the RequestCycle
nothing hangs around then. Component state doesnt change (think for example of terracotta)
i think this is also pretty clean, Session feedback -> session, Request feedback -> RequestCycle.
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491673 ]
Igor Vaynberg commented on WICKET-499:
--------------------------------------
@johan: fine by me
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-499:
--------------------------------
Fix Version/s: (was: trunk)
If you're going to fix this for 1.3.0 final, please update your intended fix version. Given it's unassigned currently, I'm leaving this as something for the nebulous future.
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Eelco Hillenius
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius reassigned WICKET-499:
--------------------------------------
Assignee: Igor Vaynberg (was: Eelco Hillenius)
I'm comfortable with the way it is implemented now. If you want to put your stamp on it again, go for it. Otherwise close it.
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3.0-beta1
> Reporter: Eelco Hillenius
> Assignee: Igor Vaynberg
> Fix For: 1.4.0-alpha
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491684 ]
Eelco Hillenius commented on WICKET-499:
----------------------------------------
@johan. They are always cleaned up now, but there can be special occurances where messages should be carried over.
That's the last case to cover, and the reason for looking beyond what we have now (which I believe is at least more optimal in processing). Putting it in the request cycle doesn't solve anything over what we have now except that you would leave cleanup for garbage collection.
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-499:
-----------------------------------
Fix Version/s: 1.4.0-alpha
Assignee: Igor Vaynberg
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Eelco Hillenius
> Assignee: Igor Vaynberg
> Fix For: 1.4.0-alpha
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491513 ]
Igor Vaynberg commented on WICKET-499:
--------------------------------------
* no central storage place, making it harder to track.
i disagree this is a con. component and session messages are different, and as you have learned yourself it is a huge pain to keep them together. two+ weeks after you made the change we are still finding cases where it doesnt work.
* probably less efficient in both storage and processing.
but proper cleanup is trivial. component.ondetach() { setmetadata(feedbackkey, null); }
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-499:
------------------------------------
Assignee: Eelco Hillenius (was: Igor Vaynberg)
i thought we decided to use requestcycle to store request scoped feedback messages?
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3.0-beta1
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.4.0-alpha
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-499) Investigate whether we can use
component meta data for the storage of feedback messages
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492013 ]
Johan Compagner commented on WICKET-499:
----------------------------------------
no it also ' fixes' the problem that we don't alter component state that only is there for the duration of the request.
Thats again better for for example for terracotta.
Also if you do it in the component then you need to walk over all of them when you need them. Thats again cpu consuming.
But there is one problem with the request cycle (and also the other impl i have seens so far):
public static final IRequestCycleSettings.RenderStrategy REDIRECT_TO_RENDER = new IRequestCycleSettings.RenderStrategy(
"CLIENT_SIDE_REDIRECT");
If that is enabled we have to wait one request more before we can cleanup anything.
(and igor: how should the attach/beforerender/afterender/detach then work?)
> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-499
> URL: https://issues.apache.org/jira/browse/WICKET-499
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.