You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2017/10/06 04:33:04 UTC
Review Request 62797: ATLAS-2192: Split Join Messages Improved Logging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62797/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2190
https://issues.apache.org/jira/browse/ATLAS-2190
Repository: atlas
Description
-------
**Implementation**
- Added _SplitMessageAggregator_ that encapsulates some of the functionality of _AtlasNotificationStringMessage_ buffer.
- Added mechanism to detect stale split messages and evict them with appropriate message in the log.
Diffs
-----
common/src/main/java/org/apache/atlas/AtlasConfiguration.java 451bd9d8
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java 3d802840
notification/src/main/java/org/apache/atlas/notification/SplitMessageAggregator.java PRE-CREATION
notification/src/test/java/org/apache/atlas/notification/SplitMessageAggregatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/62797/diff/1/
Testing
-------
**Unit tests**
- Added existing.
- Executed existing.
**Functional testing**
- Executed tests with large messages.
Thanks,
Ashutosh Mestry
Re: Review Request 62797: ATLAS-2192: Split Join Messages Improved
Logging
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62797/
-----------------------------------------------------------
(Updated Oct. 6, 2017, 10:48 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Updates include:
- Added messages metrics.
- Additional fields in _AtlasNotificationMessage_.
- Updated hive hook to set new fields.
Bugs: ATLAS-2190
https://issues.apache.org/jira/browse/ATLAS-2190
Repository: atlas
Description
-------
**Implementation**
- Added _SplitMessageAggregator_ that encapsulates some of the functionality of _AtlasNotificationStringMessage_ buffer.
- Added mechanism to detect stale split messages and evict them with appropriate message in the log.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConfiguration.java 451bd9d8
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java a8609e6b
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 6a707346
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessage.java 2f6f9c71
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java 3d802840
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java 193735c1
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java a7878624
notification/src/main/java/org/apache/atlas/notification/SplitMessageAggregator.java PRE-CREATION
notification/src/test/java/org/apache/atlas/notification/SplitMessageAggregatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/62797/diff/2/
Changes: https://reviews.apache.org/r/62797/diff/1-2/
Testing
-------
**Unit tests**
- Added existing.
- Executed existing.
**Functional testing**
- Executed tests with large messages.
Thanks,
Ashutosh Mestry