You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 18:02:04 UTC
[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for
GarbageCollectorThread
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003181#comment-16003181 ]
ASF GitHub Bot commented on BOOKKEEPER-1051:
--------------------------------------------
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/141
BOOKKEEPER-1051: Fast shutdown for GarbageCollectorThread
Several unit tests are taking very long time to complete (eg: `BookieLedgerIndexTest` taking ~10 minutes).
The reason is that these tests are playing with the ZK quorum shutting it down and after the test succeeds, the shutdown phase is taking long time, since we try to do graceful shutdown with 1min wait time.
I think is better to interrupt immediately the garbage collector thread when shutting down the bookie.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper fast-gc-thread-shutdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
----
> Fast shutdown for GarbageCollectorThread
> ----------------------------------------
>
> Key: BOOKKEEPER-1051
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1051
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Minor
> Fix For: 4.5.0
>
>
> Several unit tests are taking very long time to complete (eg: {{BookieLedgerIndexTest}} taking ~10 minutes).
> The reason is that these tests are playing with the ZK quorum shutting it down and after the test succeeds, the shutdown phase is taking long time, since we try to do graceful shutdown with 1min wait time.
> I think is better to interrupt immediately the garbage collector thread when shutting down the bookie.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)