[GitHub] [arrow-rs] appletreeisyellow commented on a diff in pull request #3912: Add AsArray trait for more ergonomic downcasting

["appletreeisyellow (via GitHub)" <gi...@apache.org>]

appletreeisyellow commented on code in PR #3912:
URL: https://github.com/apache/arrow-rs/pull/3912#discussion_r1146660972


##########
arrow-array/src/builder/generic_byte_run_builder.rs:
##########
@@ -368,7 +368,7 @@ pub type LargeStringRunBuilder<K> = GenericByteRunBuilder<K, LargeUtf8Type>;
 ///
 /// // Values are polymorphic and so require a downcast.
 /// let av = array.values();
-/// let ava: &BinaryArray = as_generic_binary_array::<i32>(av.as_ref());
+/// let ava: &BinaryArray = av.as_binary();

Review Comment:
   Awesome! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org