You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Marta Kuczora via Review Board <no...@reviews.apache.org> on 2018/02/05 18:01:03 UTC
Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/
-----------------------------------------------------------
Review request for hive, Peter Vary and Adam Szita.
Bugs: HIVE-18580
https://issues.apache.org/jira/browse/HIVE-18580
Repository: hive-git
Description
-------
The following methods of IMetaStoreClient are covered by this test.
- int Partition exchange_partition(Map<String, String>, String, String, String, String)
- List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
The test covers not just the happy pathes, but the edge cases as well.
Diffs
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65507/diff/1/
Testing
-------
Ran the tests
Thanks,
Marta Kuczora
Re: Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Feb. 7, 2018, 11:25 a.m., Peter Vary wrote:
> > Ship It!
Thanks a lot Peter for the review.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/#review196982
-----------------------------------------------------------
On Feb. 5, 2018, 6:01 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65507/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:01 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18580
> https://issues.apache.org/jira/browse/HIVE-18580
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - int Partition exchange_partition(Map<String, String>, String, String, String, String)
> - List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65507/diff/1/
>
>
> Testing
> -------
>
> Ran the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/#review196982
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Feb. 5, 2018, 6:01 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65507/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:01 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18580
> https://issues.apache.org/jira/browse/HIVE-18580
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - int Partition exchange_partition(Map<String, String>, String, String, String, String)
> - List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65507/diff/1/
>
>
> Testing
> -------
>
> Ran the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 3:35 p.m.)
Review request for hive, Peter Vary and Adam Szita.
Changes
-------
Fixed the review findings.
Bugs: HIVE-18580
https://issues.apache.org/jira/browse/HIVE-18580
Repository: hive-git
Description
-------
The following methods of IMetaStoreClient are covered by this test.
- int Partition exchange_partition(Map<String, String>, String, String, String, String)
- List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
The test covers not just the happy pathes, but the edge cases as well.
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65507/diff/2/
Changes: https://reviews.apache.org/r/65507/diff/1-2/
Testing
-------
Ran the tests
Thanks,
Marta Kuczora
Re: Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Feb. 7, 2018, 10:16 a.m., Adam Szita wrote:
> > Thanks for the patch Marta, this is incredibly thourough!
Thanks a lot Adam for the review.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/#review196979
-----------------------------------------------------------
On Feb. 5, 2018, 6:01 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65507/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:01 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18580
> https://issues.apache.org/jira/browse/HIVE-18580
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - int Partition exchange_partition(Map<String, String>, String, String, String, String)
> - List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65507/diff/1/
>
>
> Testing
> -------
>
> Ran the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65507: HIVE-18580: Create tests to cover exchange
partitions
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65507/#review196979
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for the patch Marta, this is incredibly thourough!
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java
Lines 1480-1501 (patched)
<https://reviews.apache.org/r/65507/#comment277012>
I'd mark these helper methods as static
- Adam Szita
On Feb. 5, 2018, 6:01 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65507/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:01 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18580
> https://issues.apache.org/jira/browse/HIVE-18580
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - int Partition exchange_partition(Map<String, String>, String, String, String, String)
> - List<Partition> Partition exchange_partition(Map<String, String>, String, String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65507/diff/1/
>
>
> Testing
> -------
>
> Ran the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>