You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2022/10/13 23:25:12 UTC
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19140
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
IMPALA-11661: Added new api in MetastoreServiceHandler for
find_next_compact2 method
In the MetastoreServiceHandler class, find_next_compact2 API
implementation is missing which is causing test failures.
This need to be fixed by adding implementation of
find_next_compact2 api in the MetastoreServiceHandler class
Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/19140/1
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Some nits, otherwise LGTM.
http://gerrit.cloudera.org:8080/#/c/19140/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19140/3//COMMIT_MSG@12
PS3, Line 12: need
Nit: needs
http://gerrit.cloudera.org:8080/#/c/19140/3/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/3/tests/custom_cluster/test_metastore_service.py@989
PS3, Line 989: talk
Nit: talk to
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 09:40:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8961/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 02:51:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 1:
Can we add tests that verify that the implementation of 'find_next_compact2' exists and works correctly?
We usually add a paragraph in the commit message like this:
Testing:
- added test xxx that does yyy etc.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Oct 2022 16:32:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19140/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/19140/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2290
PS1, Line 2290:
To follow the convention, we should use 4 space indent here.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Sat, 15 Oct 2022 18:27:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12131/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 00:27:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Yu-Wen Lai, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19140
to look at the new patch set (#4).
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
IMPALA-11661: Added new api in MetastoreServiceHandler for
find_next_compact2 method
In the MetastoreServiceHandler class, the 'find_next_compact2'
API implementation is missing which is causing test failures.
This needs to be fixed by adding implementation of the
'find_next_compact2' api in the MetastoreServiceHandler class
Testing:
Added a test 'test_compaction_apis()' to verify that the
'find_next_compact2' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/19140/4
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 08:02:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py@27
PS2, Line 27: from hive_metastore.ttypes import SerDeInfo
> nit: move this to line 21 to keep the import list sorted
Ack
http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py@1005
PS2, Line 1005: compactRequest.workerId = "myworker"
> Should we verify the result?
I don't think that is required. This is a dummy call, I don't know what exactly I need to verify in the result. Also, since there are no delta files for compaction, it'll be empty compaction. The purpose of this test is to verify if a particular API in HMS is reachable or not.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 00:10:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Yu-Wen Lai, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19140
to look at the new patch set (#3).
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
IMPALA-11661: Added new api in MetastoreServiceHandler for
find_next_compact2 method
In the MetastoreServiceHandler class, the 'find_next_compact2'
API implementation is missing which is causing test failures.
This need to be fixed by adding implementation of the
'find_next_compact2' api in the MetastoreServiceHandler class
Testing:
Added a test 'test_compaction_apis()' to verify that the
'find_next_compact2' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/19140/3
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py@1007
PS4, Line 1007: o
flake8: F841 local variable 'optionalCi' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 20:17:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11631/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Oct 2022 23:45:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
IMPALA-11661: Added new api in MetastoreServiceHandler for
find_next_compact2 method
In the MetastoreServiceHandler class, the 'find_next_compact2'
API implementation is missing which is causing test failures.
This needs to be fixed by adding implementation of the
'find_next_compact2' api in the MetastoreServiceHandler class
Testing:
Added a test 'test_compaction_apis()' to verify that the
'find_next_compact2' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Reviewed-on: http://gerrit.cloudera.org:8080/19140
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19140/5/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/5/tests/custom_cluster/test_metastore_service.py@1007
PS5, Line 1007: o
flake8: F841 local variable 'optionalCi' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:42:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19140/3/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/3/tests/custom_cluster/test_metastore_service.py@1007
PS3, Line 1007: o
flake8: F841 local variable 'optionalCi' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 00:08:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12152/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 02:01:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 5: Code-Review+2
LGTM. Carrying Daniel's +1.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 02:50:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Jan 2023 11:48:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 02:51:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
LGTM. I can bump to +2 after the comments are addressed.
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py@1009
PS4, Line 1009: finally:
nit: we'd better drop the table at the end.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:03:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Yu-Wen Lai, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19140
to look at the new patch set (#5).
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
IMPALA-11661: Added new api in MetastoreServiceHandler for
find_next_compact2 method
In the MetastoreServiceHandler class, the 'find_next_compact2'
API implementation is missing which is causing test failures.
This needs to be fixed by adding implementation of the
'find_next_compact2' api in the MetastoreServiceHandler class
Testing:
Added a test 'test_compaction_apis()' to verify that the
'find_next_compact2' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.
Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 47 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/19140/5
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py@1009
PS4, Line 1009: catalog_hms_client.drop_table("default", tbl_name, True)
> nit: we'd better drop the table at the end.
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:42:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11661: Added new api in MetastoreServiceHandler for find next compact2 method
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12141/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Jan 2023 20:37:03 +0000
Gerrit-HasComments: No