[GitHub] [spark] cloud-fan commented on a change in pull request #35070: [SPARK-37789][SQL] Add a class to represent general aggregate functions in DS V2

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35070:
URL: https://github.com/apache/spark/pull/35070#discussion_r776766407



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Expression.java
##########
@@ -29,5 +29,5 @@
   /**
    * Format the expression as a human readable SQL-like string.
    */
-  String describe();
+  default String describe() { return this.toString(); }

Review comment:
       I realized that almost all the implementations override both `toString` and `describe`, so making this change to make it simpler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org