You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2020/10/11 13:55:26 UTC

[GitHub] [incubator-sedona] Imbruced opened a new pull request #485: Jtsplus python fix

Imbruced opened a new pull request #485:
URL: https://github.com/apache/incubator-sedona/pull/485


   ## Is this PR related to a proposed Issue?
   #484 
   ## What changes were proposed in this PR?
   Fix failing python tests
   
   ## How was this patch tested?
   -
   ## Did this PR include necessary documentation updates?
   No


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #485: Jtsplus python fix

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #485:
URL: https://github.com/apache/incubator-sedona/pull/485#issuecomment-707294048


   @Imbruced That sounds good!
   
   Let's do it in a separate PR. The next PR in Sedona will be the name change for all paths, then you can finalize the wheel file there. We will have to generate our first Apache release on Spark 3.0 ASAP. Many users are waiting for it.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Imbruced commented on pull request #485: Jtsplus python fix

Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #485:
URL: https://github.com/apache/incubator-sedona/pull/485#issuecomment-706955991


   @jiayuasu 
   1. Files are used by few tests.
   2. I can try to create additional jar file which will be published on PyPI with wheel files (consists of those missing dependencies).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #485: Jtsplus python fix

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #485:
URL: https://github.com/apache/incubator-sedona/pull/485


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Imbruced commented on pull request #485: Jtsplus python fix

Posted by GitBox <gi...@apache.org>.
Imbruced commented on pull request #485:
URL: https://github.com/apache/incubator-sedona/pull/485#issuecomment-706709177


   @jiayuasu That's PR to resolve an issue with Python tests. But one thing worries me. Can we add to POM, definition of fat jar for Python purposes ? Currently to make it work I have to add additional jars, which may not be user friendly and in addition it causes continuous CI script modification when we change dependencies versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org