You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/14 11:36:00 UTC
[jira] [Commented] (FLINK-8653) Remove slot request timeout from
SlotPool
[ https://issues.apache.org/jira/browse/FLINK-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363838#comment-16363838 ]
ASF GitHub Bot commented on FLINK-8653:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5483
[FLINK-8653] [flip6] Remove internal slot request timeout from SlotPool
## What is the purpose of the change
Instead of using the internal slot request timeout to time out pending slot requests,
we use the timeout passed to SlotPool#allocateSlot to time out pending slot requests.
This PR is based on #5475.
## Verifying this change
This change is already covered by existing tests, such as `SlotPoolTest` and `SlotPoolRpcTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink removeSlotPoolRequestTimeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5483
----
commit d9159228091cae9ebbd1bb718b69e6cf452881e1
Author: Till Rohrmann <tr...@...>
Date: 2018-02-13T11:41:44Z
[FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in ExecutionGraph
This commit changes the initialization of the ExecutionGraph to use the
JobManagerOptions#SLOT_REQUEST_TIMEOUT for the slot allocation. Furthermore,
it changes the behaviour of the SlotPool#ProviderAndOwner implementation such
that the timeout is given to it via the SlotProvider#allocateSlot call.
commit 19780c9d284914ec51e92231536315299a3c2da3
Author: Till Rohrmann <tr...@...>
Date: 2018-02-13T12:18:01Z
[hotfix] [flip6] Remove unnecessary timeout from SlotPool
commit cecd949c1fcc2c16170d245d0bb5acef96b553c8
Author: Till Rohrmann <tr...@...>
Date: 2018-02-14T11:09:01Z
[FLINK-8653] [flip6] Remove internal slot request timeout from SlotPool
Instead of using the internal slot request timeout to time out pending slot requests,
we use the timeout passed to SlotPool#allocateSlot to time out pending slot requests.
----
> Remove slot request timeout from SlotPool
> -----------------------------------------
>
> Key: FLINK-8653
> URL: https://issues.apache.org/jira/browse/FLINK-8653
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> After addressing FLINK-8643, we can further simplify the {{SlotPool}} by replacing the internal slot request timeout by the timeout given to {{SlotPool#allocateSlot}}. Since this request will timeout on the {{ProviderAndOwner}} side anyway, we should do the same on the {{SlotPool}} side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)