Re: [PR] GUACAMOLE-1524: Importing LDAPS certificate into docker container and GUACAMOLE-1746: Docker Allow usage of custom keystore and custom certificat [guacamole-client]

["necouchman (via GitHub)" <gi...@apache.org>]

necouchman commented on PR #1068:
URL: https://github.com/apache/guacamole-client/pull/1068#issuecomment-2706679205

   @tiborauer Thank you for picking this up. Aside from the actual changes, there are a couple of logistical things that need to be addressed with this pull request:
   * Please choose a single Jira item and tag it with that, don't try to do both. I'd recommend using 1746, as it is still open and 1524 is closed.
   * All of your commit messages need to be tagged with the `GUACAMOLE-1746:` prefix.
   * Your commit messages are going to need to be updated a bit to be more descriptive - the message should not be duplicated, and they should describe what the commit entails without just duplicating the content of the commit. See https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/ for some hints on that :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org