You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/05 19:08:59 UTC
Review Request 41937: Factored out parsing `QuotaInfo` from JSON into
a function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41937/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Bugs: MESOS-4058
https://issues.apache.org/jira/browse/MESOS-4058
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498
Diff: https://reviews.apache.org/r/41937/diff/
Testing
-------
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON
into a function.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41937/#review113987
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 6:08 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41937/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 6:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4058
> https://issues.apache.org/jira/browse/MESOS-4058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498
>
> Diff: https://reviews.apache.org/r/41937/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.5
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON
into a function.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41937/#review114759
-----------------------------------------------------------
I still don't like the fact that we are taking a generic helper function and forcing people to create json to be able to use it.
Let's move ahead with the protobuf wrapper approach we discussed with benh. I think this will allow us to have a more useful argument to this helper function.
- Joris Van Remoortere
On Jan. 12, 2016, 9:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41937/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 9:32 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4058
> https://issues.apache.org/jira/browse/MESOS-4058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 134a93b1d1b6e050aa8a5037ffbec2cc305b0694
>
> Diff: https://reviews.apache.org/r/41937/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.5
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON
into a function.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41937/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:32 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-4058
https://issues.apache.org/jira/browse/MESOS-4058
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/quota_handler.cpp 134a93b1d1b6e050aa8a5037ffbec2cc305b0694
Diff: https://reviews.apache.org/r/41937/diff/
Testing
-------
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov