You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/08 08:16:41 UTC

[GitHub] [pulsar-client-reactive] lhotari opened a new pull request, #101: Fix ASF release requirements

lhotari opened a new pull request, #101:
URL: https://github.com/apache/pulsar-client-reactive/pull/101

   - see https://lists.apache.org/thread/87of21sctklvhx8hvg67hs30od8n3n0d
   
   - add missing license headers
   - add NOTICE file
   - configure RAT plugin to check license headers
   - add Gradle task "sourceTar" that will create a .tar.gz package without the Gradle wrapper (similar solution is used in Apache Calcite, Gradle wrapper remains in the Git repository)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-reactive] cbornet merged pull request #101: Fix ASF release requirements

Posted by GitBox <gi...@apache.org>.
cbornet merged PR #101:
URL: https://github.com/apache/pulsar-client-reactive/pull/101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-reactive] cbornet commented on a diff in pull request #101: Fix ASF release requirements

Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #101:
URL: https://github.com/apache/pulsar-client-reactive/pull/101#discussion_r1043118250


##########
build.gradle:
##########
@@ -21,4 +21,43 @@ plugins {
 allprojects {
     group = 'org.apache.pulsar'
     apply plugin: 'io.spring.javaformat'
+	apply plugin: 'org.nosphere.apache.rat'
+
+	repositories {
+		mavenCentral()
+	}
+
+	tasks.named('rat') {
+		inputDir = projectDir
+		excludes = ['.asf.yaml', // ASF metadata for github integration excluded from src zip
+					'**/.gradle/**', '**/wrapper/**', 'gradlew*',  // gradle wrapper files excluded from src zip
+					'gradle.properties',  // artifactory release plugin removes header when bumping version
+					'**/build/**', '**/target/**', 'licenses/**', 'notices/**',
+					'**/META-INF/services/*',
+					'out/**', '*.ipr', '**/*.iml', '*.iws', '.idea/**', // Intellij files
+					'.classpath', '.project', '.settings/**', 'bin/**', // Eclipse files
+					'CONTRIBUTING.adoc', 'README.adoc',

Review Comment:
   Pulsar core has license headers for these files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org