You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:30:12 UTC

[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #5293: [ISSUE #5292] [RIP-48] Support reset offset in server-side to improve the success rate

xdkxlk commented on code in PR #5293:
URL: https://github.com/apache/rocketmq/pull/5293#discussion_r994322148


##########
common/src/main/java/org/apache/rocketmq/common/protocol/header/ResetOffsetRequestHeader.java:
##########
@@ -22,12 +22,21 @@
 import org.apache.rocketmq.remoting.exception.RemotingCommandException;
 
 public class ResetOffsetRequestHeader implements CommandCustomHeader {
+
     @CFNotNull
     private String topic;
+
     @CFNotNull
     private String group;
+
+    private int queueId = -1;
+
+    @CFNotNull
+    private Long offset;

Review Comment:
   The CFNotNull of offset is not necessary, and will produce WARN for old client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org