You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/12/03 10:09:31 UTC
[PR] remove `unalias` TableScan filters [arrow-datafusion]
jackwener opened a new pull request, #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
- remove `unalias` TableScan filters
- refactor CreateExternalTable
- fix typo
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove `unalias` TableScan filters when create Physical Filter [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404#discussion_r1413082373
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner {
// doesn't know (nor should care) how the relation was
// referred to in the query
let filters = unnormalize_cols(filters.iter().cloned());
- let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect();
Review Comment:
Yes, theoretically and in terms of code, the alias in the filter expression does not affect the schema or output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove `unalias` TableScan filters when create Physical Filter [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404#discussion_r1413075898
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner {
// doesn't know (nor should care) how the relation was
// referred to in the query
let filters = unnormalize_cols(filters.iter().cloned());
- let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect();
Review Comment:
I think we have to rely on our test coverage here, and given all the existing tests pass I agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove `unalias` TableScan filters [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404#discussion_r1413040294
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner {
// doesn't know (nor should care) how the relation was
// referred to in the query
let filters = unnormalize_cols(filters.iter().cloned());
- let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect();
Review Comment:
It's useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove `unalias` TableScan filters when create Physical Filter [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove `unalias` TableScan filters when create Physical Filter [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404#discussion_r1413082373
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner {
// doesn't know (nor should care) how the relation was
// referred to in the query
let filters = unnormalize_cols(filters.iter().cloned());
- let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect();
Review Comment:
Yes, existing tests already cover it.
BTW, theoretically and in terms of code, the alias in the filter expression does not affect the schema or output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org