[GitHub] merlimat opened a new pull request #1279: Fixed DbStorage write cache segment index computation

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #1279: Fixed DbStorage write cache segment index computation
URL: https://github.com/apache/bookkeeper/pull/1279
 
 
   When the write cache was merged from `yahoo-4.3` branch into master, an improvement went in around computing the the write cache segment index (doing shift instead of division) and that introduced a problem. 
   
   The write cache is broken into multiple segments (since buffers in JVM can only be at most 2GB). By default we use 1GB segments (or smaller if the write cache is overall smaller).
   
   Because the shift count was wrong, the entries in the first segment were being ovrridden by entries in the 2nd segment (entries in the other segments were all fine). 
   
   That would lead to write some garbage in the entry log and subsequent read failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services