You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by mreve <gi...@git.apache.org> on 2015/04/24 17:53:35 UTC
[GitHub] thrift pull request: Support negative hex literals in IDL
GitHub user mreve opened a pull request:
https://github.com/apache/thrift/pull/461
Support negative hex literals in IDL
As it is now, the parser doesn't allow hex constant values to be negative (it throws a 'bad syntax' error).
The change updates the regex and the code that parses the hex value from the string read from the IDL file to support negative values.
Jira issue: https://issues.apache.org/jira/browse/THRIFT-233
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mreve/thrift THRIFT-233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/461.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #461
----
commit 5c14cea3d612d026279b354556472c22647261b9
Author: mreve <aa...@gmail.com>
Date: 2015-04-19T11:16:45Z
Update hexconstant regex in thriftl.ll
As it is now, the parser doesn't allow hex constant values to be negative (it throws a 'bad syntax' error).
The change updates the regex and the part that parses the hex value from the string read from the IDL file to support negative values.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Support negative hex literals in IDL
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---