You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/13 16:02:24 UTC
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request, #164: feat: support for handling upstream responses
tzssangglass opened a new pull request, #164:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/164
Closes #102
Signed-off-by: tzssangglass <tz...@gmail.com>
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related issues #102
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #164: feat: support filter upstream responses
Posted by GitBox <gi...@apache.org>.
tzssangglass merged PR #164:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] soulbird commented on a diff in pull request #164: feat: support filter upstream responses
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #164:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/164#discussion_r921729477
##########
runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/PostResponse.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner;
+
+import com.google.flatbuffers.FlatBufferBuilder;
+import io.github.api7.A6.HTTPRespCall.Resp;
+import io.github.api7.A6.TextEntry;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
+
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+
+public class PostResponse implements A6Response {
+
+ private final Logger logger = LoggerFactory.getLogger(PostResponse.class);
+
+ private final long requestId;
+
+ private String body;
+
+ private Integer statusCode;
+
+ private Map<String, String> headers;
+
+ public PostResponse(long requestId) {
+ this.requestId = requestId;
+ }
+
+ @Override
+ public ByteBuffer encode() {
+ FlatBufferBuilder builder = new FlatBufferBuilder();
+
+ int bodyIndex = -1;
+ if (StringUtils.hasText(body)) {
+ byte[] bodyBytes = body.getBytes(StandardCharsets.UTF_8);
+ bodyIndex = Resp.createBodyVector(builder, bodyBytes);
+ }
+
+ int headerIndex = -1;
+ if (!CollectionUtils.isEmpty(headers)) {
+ int[] headerTexts = new int[headers.size()];
+ int i = -1;
+ for (Map.Entry<String, String> header : headers.entrySet()) {
+ int key = builder.createString(header.getKey());
+ int value = 0;
+ if (!Objects.isNull(header.getValue())) {
+ value = builder.createString(header.getValue());
+ }
+ int text = TextEntry.createTextEntry(builder, key, value);
+ headerTexts[++i] = text;
+ }
+ headerIndex = Resp.createHeadersVector(builder, headerTexts);
+ }
+
+ Resp.startResp(builder);
+ Resp.addId(builder, this.requestId);
+
+ if (-1 != bodyIndex) {
+ Resp.addBody(builder, bodyIndex);
+
+ }
+
+ if (-1 != headerIndex) {
+ Resp.addHeaders(builder, headerIndex);
+ }
+
+ if (!Objects.isNull(statusCode)) {
+ Resp.addStatus(builder, this.statusCode);
+ }
+
+ builder.finish(Resp.endResp(builder));
+ return builder.dataBuffer();
+ }
+
+ @Override
+ public byte getType() {
+ return 4;
+ }
+
+ @Override
+ public A6ErrResponse getErrResponse() {
+ return A6Response.super.getErrResponse();
+ }
+
+ public void setStatusCode(Integer code) {
+ }
Review Comment:
repeated？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a diff in pull request #164: feat: support filter upstream responses
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #164:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/164#discussion_r921762922
##########
runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/PostResponse.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.apisix.plugin.runner;
+
+import com.google.flatbuffers.FlatBufferBuilder;
+import io.github.api7.A6.HTTPRespCall.Resp;
+import io.github.api7.A6.TextEntry;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.util.CollectionUtils;
+import org.springframework.util.StringUtils;
+
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+
+public class PostResponse implements A6Response {
+
+ private final Logger logger = LoggerFactory.getLogger(PostResponse.class);
+
+ private final long requestId;
+
+ private String body;
+
+ private Integer statusCode;
+
+ private Map<String, String> headers;
+
+ public PostResponse(long requestId) {
+ this.requestId = requestId;
+ }
+
+ @Override
+ public ByteBuffer encode() {
+ FlatBufferBuilder builder = new FlatBufferBuilder();
+
+ int bodyIndex = -1;
+ if (StringUtils.hasText(body)) {
+ byte[] bodyBytes = body.getBytes(StandardCharsets.UTF_8);
+ bodyIndex = Resp.createBodyVector(builder, bodyBytes);
+ }
+
+ int headerIndex = -1;
+ if (!CollectionUtils.isEmpty(headers)) {
+ int[] headerTexts = new int[headers.size()];
+ int i = -1;
+ for (Map.Entry<String, String> header : headers.entrySet()) {
+ int key = builder.createString(header.getKey());
+ int value = 0;
+ if (!Objects.isNull(header.getValue())) {
+ value = builder.createString(header.getValue());
+ }
+ int text = TextEntry.createTextEntry(builder, key, value);
+ headerTexts[++i] = text;
+ }
+ headerIndex = Resp.createHeadersVector(builder, headerTexts);
+ }
+
+ Resp.startResp(builder);
+ Resp.addId(builder, this.requestId);
+
+ if (-1 != bodyIndex) {
+ Resp.addBody(builder, bodyIndex);
+
+ }
+
+ if (-1 != headerIndex) {
+ Resp.addHeaders(builder, headerIndex);
+ }
+
+ if (!Objects.isNull(statusCode)) {
+ Resp.addStatus(builder, this.statusCode);
+ }
+
+ builder.finish(Resp.endResp(builder));
+ return builder.dataBuffer();
+ }
+
+ @Override
+ public byte getType() {
+ return 4;
+ }
+
+ @Override
+ public A6ErrResponse getErrResponse() {
+ return A6Response.super.getErrResponse();
+ }
+
+ public void setStatusCode(Integer code) {
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org