You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/01/25 02:06:32 UTC

[PR] Ant: fix GeneratedFilesHelper CRC cache [netbeans]

mbien opened a new pull request, #8190:
URL: https://github.com/apache/netbeans/pull/8190

   Cache used the xor function of timestamp and size as modification indicator for a CRC cache. This produced frequent collisions esp when timestamp and size were close together between two modifications.
   
   example write to a file 3 ms apart which adds 5 bytes: 
   ```
   1737766006001L ^ 208
   1737766006004L ^ 213
   ```
   produces the same value -> thinks there was no modification
   
   fix: store both values without combiner function
   
   fixes the first item on https://github.com/apache/netbeans/issues/8183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Ant: fix GeneratedFilesHelper CRC cache [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8190:
URL: https://github.com/apache/netbeans/pull/8190#issuecomment-2629439520

   thanks for review, planning to merge this after rc2 synced back to master, since this stabilizes CI a bit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Ant: fix GeneratedFilesHelper CRC cache [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8190:
URL: https://github.com/apache/netbeans/pull/8190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists