You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/29 01:38:25 UTC
[GitHub] [spark] imback82 opened a new pull request #34429: [WIP][SPARK-37150][SQL] Migrate SHOW TABLES to use V2 command by default
imback82 opened a new pull request #34429:
URL: https://github.com/apache/spark/pull/34429
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955681722
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144788/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955023713
**[Test build #144768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144768/testReport)** for PR 34429 at commit [`988187c`](https://github.com/apache/spark/commit/988187ca7c87527c9e672eec704f2346417458c0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955150619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144768/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955648381
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r739759163
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -44,10 +44,13 @@ case class DescribeNamespaceExec(
}
if (isExtended) {
- val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
- if (properties.nonEmpty) {
- rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
+ val properties = metadata.asScala.toMap -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
Review comment:
I just changed the command to sort the properties by keys (similar to `show tblproperties`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954424295
**[Test build #144729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144729/testReport)** for PR 34429 at commit [`8fa5201`](https://github.com/apache/spark/commit/8fa52012c9051312336e0a49b450683d478c08d6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954990032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955078422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955023713
**[Test build #144768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144768/testReport)** for PR 34429 at commit [`988187c`](https://github.com/apache/spark/commit/988187ca7c87527c9e672eec704f2346417458c0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955642919
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34429:
URL: https://github.com/apache/spark/pull/34429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r738880189
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -45,9 +45,13 @@ case class DescribeNamespaceExec(
if (isExtended) {
val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
- if (properties.nonEmpty) {
- rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
- }
+ val propertiesStr =
+ if (properties.isEmpty) {
+ ""
+ } else {
+ properties.toSeq.mkString("(", ", ", ")")
+ }
+ rows += toCatalystRow("Properties", propertiesStr)
Review comment:
@cloud-fan There are the differences between v1 and v2 command:
1. For extended mode, v1 command prints the "Properties" row with an empty string whereas v2 command doesn't print the row if there are no properties.
2. v1 command puts extra space after `,` among properties: e.g., `((a,b), (c,d))` in v1 vs. `((a,b),(c,d))` in v2.
3. v1 command uses `Database Name` vs. `Namespace Name` in v2.
`1)` and `2)` are easy to resolve (e.g., just follow v1 behavior), but I wasn't sure the best way to address `3)`. Do we need to unify this property name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955650238
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954415932
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49198/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954404356
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49198/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955639719
**[Test build #144788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144788/testReport)** for PR 34429 at commit [`8da0022`](https://github.com/apache/spark/commit/8da00228c2c09deebde461c2769afcd29392fd1b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r739511298
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -44,10 +44,13 @@ case class DescribeNamespaceExec(
}
if (isExtended) {
- val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
- if (properties.nonEmpty) {
- rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
+ val properties = metadata.asScala.toMap -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
Review comment:
Adding `toMap` similar to https://github.com/apache/spark/blob/8238cdd443d5bc8557f7e0e76f40c66bf8715c5a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala#L321.
The Scala Map implementation uses a list underneath up to 4 elements and maintains it in the order it was inserted. So this make tests such as https://github.com/apache/spark/blob/8238cdd443d5bc8557f7e0e76f40c66bf8715c5a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala#L778 pass.
Maybe, just make the tests more robust?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954436550
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954990032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954950311
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49235/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r738880189
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -45,9 +45,13 @@ case class DescribeNamespaceExec(
if (isExtended) {
val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
- if (properties.nonEmpty) {
- rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
- }
+ val propertiesStr =
+ if (properties.isEmpty) {
+ ""
+ } else {
+ properties.toSeq.mkString("(", ", ", ")")
+ }
+ rows += toCatalystRow("Properties", propertiesStr)
Review comment:
@cloud-fan These are the differences between v1 and v2 command:
1. For extended mode, v1 command prints the "Properties" row with an empty string whereas v2 command doesn't print the row if there are no properties.
2. v1 command puts extra space after `,` among properties: e.g., `((a,b), (c,d))` in v1 vs. `((a,b),(c,d))` in v2.
3. v1 command uses `Database Name` vs. `Namespace Name` in v2.
`1)` and `2)` are easy to resolve (e.g., just follow v1 behavior), but I wasn't sure the best way to address `3)`. Do we need to unify this property name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954368364
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49198/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955078422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955072333
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954916588
**[Test build #144766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144766/testReport)** for PR 34429 at commit [`628bf4c`](https://github.com/apache/spark/commit/628bf4c50a350d476cd6ec756594b25132a0ed67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955650238
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954916588
**[Test build #144766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144766/testReport)** for PR 34429 at commit [`628bf4c`](https://github.com/apache/spark/commit/628bf4c50a350d476cd6ec756594b25132a0ed67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954356130
**[Test build #144729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144729/testReport)** for PR 34429 at commit [`8fa5201`](https://github.com/apache/spark/commit/8fa52012c9051312336e0a49b450683d478c08d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955639719
**[Test build #144788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144788/testReport)** for PR 34429 at commit [`8da0022`](https://github.com/apache/spark/commit/8da00228c2c09deebde461c2769afcd29392fd1b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955681722
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144788/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r738880464
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -180,7 +180,7 @@ case class DescribeDatabaseCommand(
sparkSession.sessionState.catalog.getDatabaseMetadata(databaseName)
val allDbProperties = dbMetadata.properties
val result =
- Row("Database Name", dbMetadata.name) ::
+ Row("Namespace Name", dbMetadata.name) ::
Review comment:
This is what we need to change in V1 to unify the behavior. More question here: https://github.com/apache/spark/pull/34429#discussion_r738880189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954415932
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49198/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955048914
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955144760
**[Test build #144768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144768/testReport)** for PR 34429 at commit [`988187c`](https://github.com/apache/spark/commit/988187ca7c87527c9e672eec704f2346417458c0).
* This patch **fails from timeout after a configured wait of `500m`**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955150619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144768/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954967357
**[Test build #144766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144766/testReport)** for PR 34429 at commit [`628bf4c`](https://github.com/apache/spark/commit/628bf4c50a350d476cd6ec756594b25132a0ed67).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954356130
**[Test build #144729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144729/testReport)** for PR 34429 at commit [`8fa5201`](https://github.com/apache/spark/commit/8fa52012c9051312336e0a49b450683d478c08d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r738930469
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -45,9 +45,13 @@ case class DescribeNamespaceExec(
if (isExtended) {
val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
- if (properties.nonEmpty) {
- rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
- }
+ val propertiesStr =
+ if (properties.isEmpty) {
+ ""
+ } else {
+ properties.toSeq.mkString("(", ", ", ")")
+ }
+ rows += toCatalystRow("Properties", propertiesStr)
Review comment:
I think it's OK to make this behavior change (database -> namespace). People can still fallback to v1 command if needed.
The tests need to be a bit more complicated though, to allow different results between v1 and v2 commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954436550
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r739438963
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DescribeNamespaceSuiteBase.scala
##########
@@ -47,4 +48,21 @@ trait DescribeNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
// TODO: Move this to DropNamespaceSuite when the test suite is introduced.
sql(s"DROP NAMESPACE IF EXISTS $catalog.$ns")
}
+
+ test("Keep the legacy output schema") {
Review comment:
This is now run for both v1/v2 catalogs.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeNamespaceSuite.scala
##########
@@ -43,35 +43,21 @@ trait DescribeNamespaceSuiteBase extends command.DescribeNamespaceSuiteBase {
.where("key not like 'Owner%'") // filter for consistency with in-memory catalog
.collect()
+ val namePrefix = if (conf.useV1Command) "Database" else "Namespace"
Review comment:
This will be the only difference b/w v1 and v2 command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955677430
**[Test build #144788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144788/testReport)** for PR 34429 at commit [`8da0022`](https://github.com/apache/spark/commit/8da00228c2c09deebde461c2769afcd29392fd1b).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-954975413
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49235/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34429:
URL: https://github.com/apache/spark/pull/34429#issuecomment-955953697
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org