You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/04 23:00:04 UTC

[GitHub] Licht-T commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client

Licht-T commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client
URL: https://github.com/apache/incubator-pulsar/pull/1029#discussion_r159777145
 
 

 ##########
 File path: pulsar-client-cpp/lib/Murmur3_32.cc
 ##########
 @@ -0,0 +1,108 @@
+/**
 
 Review comment:
   @jai1 There is various implementations of MurmurHash3. `boost::hash` is much different from the Google Guava's one which is based on the original one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services