You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2014/06/23 18:16:26 UTC
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/incubator-storm/pull/154
[STORM-366] Add color span to most recent error and fix ui templates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm show-recent-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit f0e6873fdab6ff3a2f4d7ea7867f54d8c330c819
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2014-06-23T15:46:45Z
Add color span to most recent error and fix ui templates.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/154#issuecomment-49649348
@revans2 Good catch, by default ```get-error-time```was returning "" instead now it return ```nil```. After fix, the api returned json has ```"errorLapsedSecs":null``` instead of "".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/154#issuecomment-49480371
@revans2 I have updated the restful API docs to reflect use of elapsed time and component errors. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/154#issuecomment-49372383
The changes look fine to me. I would like to see the new restful API docs updated to reflect the additional data, but other then that I am a +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/154#issuecomment-47119003
Removed tablesorter fix from this pull request and created separate https://github.com/apache/incubator-storm/pull/160 just for tablesorter fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/154#issuecomment-50695743
I am still +1. I'll merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-366] Add color span to most r...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/154#discussion_r15177952
--- Diff: STORM-UI-REST-API.md ---
@@ -246,6 +250,7 @@ Sample Response:
"spoutId": "spout",
"tasks": 5,
"lastError": "",
+ "errorLapsedSecs": "",
--- End diff --
Why is this an Empty string if it is supposed to be an integer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---